Allow Win64 build of base library even in a Win32 build.

Allow Win64 build of base library even in a Win32 build.

Some components of a 32 bit build of chrome for Windows need to be built
as Win64 Dlls.  To allow those components to use base, we make a Win64
build of the base library even when building chrome 32 bit.

This is needed by the Chrome Desk Band code. crbug.com/327435.
https://codereview.chromium.org/79173004/

BUG=327435
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243936

[Pete Williamson, 2013-12-10 23:34:32]

BrettW - Please let me know if there is a better reviewer.  You are one of the
few who is in the owners for both directories, but I'm not sure if somebody else
would be better for .gyp files.

[brettw, 2013-12-11 20:16:28]

There is also base_nacl_win64. I think we should merge these.

The only reason nacl is in the name of the old one is that it was the only user.
However, I don't think this is true now anyway, so I think we should probably
just rename it base_win64. Does this target already have what you need? If not,
we should probably just add it.

[Pete Williamson, 2013-12-18 23:29:21]

ben@chromium.org: Please review the rename changes in all gyp files except
base.gyp and modp_b64.gyp (there is only one line change per file in these
files).

BrettW: Please review all changes, especially base.gyp and modp_b64.gyp

BradNelson: Please review all changes from a "how does it affect NaCl point of
view".  Also, it might be good if I could remove the NACL_WIN64 #define from
always being turned on when I build base_win64, any suggestions?

As BrettW suggested, this change makes the base_nacl_win64 target more generic
(no longer NaCl only) so we can use it with other components.  The Upcoming
DeskBand code will use this.

[Ben Goodger (Google), 2013-12-19 18:30:26]

renames lgtm

[yukawa, 2013-12-19 20:47:21]

Sorry for jumping in, but "Did you mean: BUG=327435"

[brettw, 2013-12-19 21:06:04]

lgtm

https://codereview.chromium.org/103333004/diff/20001/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/103333004/diff/20001/base/base.gyp#newcode1059
base/base.gyp:1059: # binary that might need to be built when building a Win32
browser,
I'd change this to something simpler like "The base_win64 target here allows us
to use base for Win64 targets (the normal build is 32-bits)."

https://codereview.chromium.org/103333004/diff/20001/third_party/modp_b64/mod...
File third_party/modp_b64/modp_b64.gyp (right):

https://codereview.chromium.org/103333004/diff/20001/third_party/modp_b64/mod...
third_party/modp_b64/modp_b64.gyp:32: '../..',
Indenting

[Pete Williamson, 2013-12-20 01:52:09]

Made comment and indentation fixes suggested by BrettW.

https://codereview.chromium.org/103333004/diff/20001/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/103333004/diff/20001/base/base.gyp#newcode1059
base/base.gyp:1059: # binary that might need to be built when building a Win32
browser,
On 2013/12/19 21:06:05, brettw wrote:
> I'd change this to something simpler like "The base_win64 target here allows
us
> to use base for Win64 targets (the normal build is 32-bits)."

Done.

https://codereview.chromium.org/103333004/diff/20001/third_party/modp_b64/mod...
File third_party/modp_b64/modp_b64.gyp (right):

https://codereview.chromium.org/103333004/diff/20001/third_party/modp_b64/mod...
third_party/modp_b64/modp_b64.gyp:32: '../..',
On 2013/12/19 21:06:05, brettw wrote:
> Indenting

Done.

[Pete Williamson, 2014-01-02 18:00:06]

Ping bradnelson:  Do these changes look safe from a NaCl point of view?  (It
doesn't look like I broke anything in NaCl with this, right?)

[bradn, 2014-01-06 17:49:07]

lgtm

[commit-bot: I haz the power, 2014-01-07 17:49:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petewil@chromium.org/103333004/40001

[commit-bot: I haz the power, 2014-01-07 21:05:54]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-09 17:38:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petewil@chromium.org/103333004/40001

[commit-bot: I haz the power, 2014-01-09 18:48:08]

Change committed as 243936