Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1033283002: Changed for loop to c++11 style in chrome/browser/prerender/prerender_local_predictor.cc:573. (Closed)

Created:
5 years, 9 months ago by Olli Raula
Modified:
5 years, 8 months ago
Reviewers:
cbentzel, mmenke
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, jkarlin+watch_chromium.org, davidben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed for loop to c++11 style in chrome/browser/prerender/prerender_local_predictor.cc:573. Also added myself to AUTHORS Committed: https://crrev.com/61f0538ddac87c3c9ca0a233befc3193387efc2c Cr-Commit-Position: refs/heads/master@{#324021}

Patch Set 1 #

Total comments: 1

Patch Set 2 : added missing space #

Patch Set 3 : rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_local_predictor.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
olli.syrjala
could you review?
5 years, 9 months ago (2015-03-27 14:39:26 UTC) #1
cbentzel
Before looking at the change, I need to make sure that you are listed as ...
5 years, 8 months ago (2015-03-30 11:43:40 UTC) #3
olli.syrjala
Hi, now I should be there.
5 years, 8 months ago (2015-04-02 06:30:16 UTC) #4
cbentzel
I may be removed from prerender/OWNERS soon, but this looks fine modulo the tiny correction ...
5 years, 8 months ago (2015-04-02 12:54:20 UTC) #6
mmenke
LGTM as well.
5 years, 8 months ago (2015-04-02 13:24:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033283002/20001
5 years, 8 months ago (2015-04-07 06:24:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/12323) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-07 06:28:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033283002/40001
5 years, 8 months ago (2015-04-07 07:02:14 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-07 07:59:47 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 08:00:37 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/61f0538ddac87c3c9ca0a233befc3193387efc2c
Cr-Commit-Position: refs/heads/master@{#324021}

Powered by Google App Engine
This is Rietveld 408576698