Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1033273005: Layout descriptor must be trimmed when corresponding descriptors array is trimmed to stay in sync. (Closed)

Created:
5 years, 8 months ago by Igor Sheludko
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Layout descriptor must be trimmed when corresponding descriptors array is trimmed to stay in sync. BUG=chromium:470804 LOG=Y Committed: https://crrev.com/3cb9f132baeab26b9f14c5cf482eab6c460bcb80 Cr-Commit-Position: refs/heads/master@{#27528}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Forgot to actually trim the array #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -62 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/layout-descriptor.h View 1 2 chunks +23 lines, -1 line 0 comments Download
M src/layout-descriptor.cc View 1 3 chunks +50 lines, -43 lines 2 comments Download
M src/layout-descriptor-inl.h View 1 2 chunks +72 lines, -12 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 7 chunks +92 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-470804.js View 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Igor Sheludko
PTAL
5 years, 8 months ago (2015-03-30 10:16:24 UTC) #4
Toon Verwaest
lgtm https://codereview.chromium.org/1033273005/diff/40001/src/layout-descriptor-inl.h File src/layout-descriptor-inl.h (right): https://codereview.chromium.org/1033273005/diff/40001/src/layout-descriptor-inl.h#newcode162 src/layout-descriptor-inl.h:162: DCHECK(num_descriptors <= descriptors->number_of_descriptors()); _LE https://codereview.chromium.org/1033273005/diff/40001/src/layout-descriptor.cc File src/layout-descriptor.cc (right): ...
5 years, 8 months ago (2015-03-30 11:42:25 UTC) #5
Igor Sheludko
I forgot to do the actual array trimming. PTAL. https://codereview.chromium.org/1033273005/diff/40001/src/layout-descriptor-inl.h File src/layout-descriptor-inl.h (right): https://codereview.chromium.org/1033273005/diff/40001/src/layout-descriptor-inl.h#newcode162 src/layout-descriptor-inl.h:162: ...
5 years, 8 months ago (2015-03-30 16:01:29 UTC) #6
Toon Verwaest
Woops, that seems relevant :) lgtm https://codereview.chromium.org/1033273005/diff/60001/src/layout-descriptor.cc File src/layout-descriptor.cc (right): https://codereview.chromium.org/1033273005/diff/60001/src/layout-descriptor.cc#newcode248 src/layout-descriptor.cc:248: heap->RightTrimFixedArray<Heap::FROM_GC>(this, delta); I ...
5 years, 8 months ago (2015-03-30 16:10:21 UTC) #7
Igor Sheludko
https://codereview.chromium.org/1033273005/diff/60001/src/layout-descriptor.cc File src/layout-descriptor.cc (right): https://codereview.chromium.org/1033273005/diff/60001/src/layout-descriptor.cc#newcode248 src/layout-descriptor.cc:248: heap->RightTrimFixedArray<Heap::FROM_GC>(this, delta); On 2015/03/30 16:10:21, Toon Verwaest wrote: > ...
5 years, 8 months ago (2015-03-30 16:33:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033273005/60001
5 years, 8 months ago (2015-03-30 16:33:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 8 months ago (2015-03-30 17:03:46 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 17:03:59 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3cb9f132baeab26b9f14c5cf482eab6c460bcb80
Cr-Commit-Position: refs/heads/master@{#27528}

Powered by Google App Engine
This is Rietveld 408576698