Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1033223008: Add record-as-much-as-possible mode for about://tracing. (Closed)

Created:
5 years, 9 months ago by nednguyen
Modified:
5 years, 9 months ago
Reviewers:
nduca, Nat
CC:
chromium-reviews, darin-cc_chromium.org, jam, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add record-as-much-as-possible mode for about://tracing. Update DEPS for trace-viewer to include the 3 tracing modes selector. BUG=396081 TEST= Committed: https://crrev.com/8e752353b04c52cb3ba1d54b79fce241c0be53d3 Cr-Commit-Position: refs/heads/master@{#322689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
nednguyen
5 years, 9 months ago (2015-03-27 21:53:39 UTC) #2
Nat
lgtm
5 years, 9 months ago (2015-03-27 21:54:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033223008/1
5 years, 9 months ago (2015-03-27 21:55:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/52444)
5 years, 9 months ago (2015-03-27 22:05:48 UTC) #8
nduca
lgtm
5 years, 9 months ago (2015-03-27 22:21:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033223008/1
5 years, 9 months ago (2015-03-27 22:53:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-28 00:47:33 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8e752353b04c52cb3ba1d54b79fce241c0be53d3 Cr-Commit-Position: refs/heads/master@{#322689}
5 years, 9 months ago (2015-03-28 00:47:55 UTC) #13
nednguyen
5 years, 8 months ago (2015-03-30 18:59:57 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1043973003/ by nednguyen@google.com.

The reason for reverting is: Speculative revert to see if this cause 340kb
increase in size (BUG=471610).

Powered by Google App Engine
This is Rietveld 408576698