tools/json_schema_compiler/h_generator.py - Issue 1033223007: [Extension API Extern Generation] Support inline object definitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/h_generator.py

Issue 1033223007: [Extension API Extern Generation] Support inline object definitions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Presubmit fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/json_schema_compiler/h_generator.py

diff --git a/tools/json_schema_compiler/h_generator.py b/tools/json_schema_compiler/h_generator.py

index 33d7a6e55c1fa87d1bd4e5f87684d9c9e143803d..566df071cd83b49026e454bd08353b5b8530b263 100644

--- a/tools/json_schema_compiler/h_generator.py

+++ b/tools/json_schema_compiler/h_generator.py

@@ -289,7 +289,7 @@ class _Generator(object):

.Append()

.Concat(self._GenerateEventNameConstant(event))

.Concat(self._GenerateCreateCallbackArguments(event))

- .Eblock('} // namespace %s' % event_namespace)

+ .Append('} // namespace %s' % event_namespace)

)

return c

« no previous file with comments | « tools/json_schema_compiler/code_test.py ('k') | tools/json_schema_compiler/js_externs_generator.py » ('j') | no next file with comments »