Issue 1033223005: webpages_playback.py: Avoid crash when retrying to capture skp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1033223005: webpages_playback.py: Avoid crash when retrying to capture skp (Closed)

Created:
5 years, 9 months ago by Kimmo Kinnunen

Modified:
5 years, 8 months ago

Reviewers:
rmistry

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@webpages-replay-filesystem

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

webpages_playback.py: Avoid crash when retrying to capture skp Move the .wpr files after recording, in the recording retry loop. Previously they were moved in the skp capture retry loop. Committed: https://skia.googlesource.com/skia/+/f9310fe2be460e2cefd844cd0f53f3e2b9f3488b

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	tools/skp/webpages_playback.py	View		2 chunks	+11 lines, -11 lines	0 comments	Download

Total messages: 7 (2 generated)

Kimmo Kinnunen

For me, chalkboard needs a retry sometimes. When it does retry, it loads fast (1.5s ...

5 years, 9 months ago (2015-03-27 14:09:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033223005/1

5 years, 8 months ago (2015-03-30 05:28:06 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-03-30 05:33:20 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f9310fe2be460e2cefd844cd0f53f3e2b9f3488b