Issue 1033163002: Revert of Use a slot that is located on a heap page when removing invalid entries from the SlotsBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1033163002: Revert of Use a slot that is located on a heap page when removing invalid entries from the SlotsBuffer. (Closed)

Created:
5 years, 9 months ago by Igor Sheludko

Modified:
5 years, 9 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Use a slot that is located on a heap page when removing invalid entries from the SlotsBuffer. (patchset #1 id:1 of https://codereview.chromium.org/1020853022/) Reason for revert: Reverting risky GC changes that block v8 roll. Original issue's description: > Use a slot that is located on a heap page when removing invalid entries from the SlotsBuffer. > > BUG=chromium:470801 > LOG=Y > > Committed: https://crrev.com/2f3a42f9a1d66ffc9d260d9700ff831c3aa1cd41 > Cr-Commit-Position: refs/heads/master@{#27467} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:470801 Committed: https://crrev.com/d23a9f7a3e509bd405e1e4b0b851e463a4a736c2 Cr-Commit-Position: refs/heads/master@{#27490}

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	src/heap/mark-compact.cc	View		2 chunks	+9 lines, -7 lines	0 comments	Download

Total messages: 1 (0 generated)

Igor Sheludko

5 years, 9 months ago (2015-03-27 06:34:16 UTC) #1

Created Revert of Use a slot that is located on a heap page when removing
invalid entries from the SlotsBuffer.