components/plugins/common/BUILD.gn - Issue 1033103002: Plugin Power Saver: Overhaul plugin-power-saver flags. Show in UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/plugins/common/BUILD.gn

Issue 1033103002: Plugin Power Saver: Overhaul plugin-power-saver flags. Show in UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix gypi i hope Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 static_library("common") {	5 static_library("common") {

6 sources = [	6 sources = [
	groby-ooo-7-16 2015/03/27 23:12:32 Question: Why make this into a component? There's Question: Why make this into a component? There's nothing really componentized? Or are you planning to move more of this into components/ ? tommycli 2015/03/28 00:40:04 This goes into the existing 'plugins' component, w Show quoted text On 2015/03/27 23:12:32, groby wrote: > Question: Why make this into a component? There's nothing really componentized? > Or are you planning to move more of this into components/ ? This goes into the existing 'plugins' component, which already contains the loadable_plugin_placeholder code. It could easily live in chrome/ also, but I'm mostly just following the omnibox example.
7 "thumbnail_score.cc",	7 "plugins_field_trial.cc",

8 "thumbnail_score.h",	8 "plugins_field_trial.h",

	9 "plugins_switches.cc",

	10 "plugins_switches.h",

9 ]	11 ]

10	12

11 deps = [	13 deps = []

12 "//base",

13 ]

14 }	14 }

OLD	NEW

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « components/plugins.gypi ('k') | components/plugins/common/OWNERS » ('j') | components/plugins/common/OWNERS » ('J')