Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 1033093002: Only destroy GPUTracer if the pointer is not empty. (Closed)

Created:
5 years, 9 months ago by David Yen
Modified:
5 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Vitaly Buka (NO REVIEWS)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only destroy GPUTracer if the pointer is not empty. R=vmiura@chromium.org BUG=471049, 467202 Committed: https://crrev.com/8ef6598843c638fe973a9f157386788341b83e4f Cr-Commit-Position: refs/heads/master@{#322498}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Applied suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
David Yen
5 years, 9 months ago (2015-03-26 22:06:12 UTC) #1
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/1033093002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/1033093002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode3759 gpu/command_buffer/service/gles2_cmd_decoder.cc:3759: if (gpu_tracer_.get()) { if (gpu_tracer_) { https://codereview.chromium.org/1033093002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode3761 gpu/command_buffer/service/gles2_cmd_decoder.cc:3761: gpu_tracer_ ...
5 years, 9 months ago (2015-03-26 22:13:41 UTC) #3
vmiura
LGTM
5 years, 9 months ago (2015-03-26 22:13:51 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 9 months ago (2015-03-26 22:14:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033093002/1
5 years, 9 months ago (2015-03-26 22:14:51 UTC) #7
David Yen
https://codereview.chromium.org/1033093002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/1033093002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode3759 gpu/command_buffer/service/gles2_cmd_decoder.cc:3759: if (gpu_tracer_.get()) { On 2015/03/26 22:13:41, Vitaly Buka wrote: ...
5 years, 9 months ago (2015-03-26 22:18:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033093002/20001
5 years, 9 months ago (2015-03-26 22:19:22 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 23:32:57 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 23:34:08 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ef6598843c638fe973a9f157386788341b83e4f
Cr-Commit-Position: refs/heads/master@{#322498}

Powered by Google App Engine
This is Rietveld 408576698