Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3046)

Issue 1033083002: Fix library name (dartanalyzer was complaining in the bots) (Closed)

Created:
5 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 4 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/source_span.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix library name (dartanalyzer was complaining in the bots) R=nweiz@google.com Committed: https://github.com/dart-lang/source_span/commit/20ebdd74e145f880dfbbca44a2b84c162023db4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/src/span_with_context.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-03-26 22:02:31 UTC) #2
nweiz
lgtm
5 years, 4 months ago (2015-03-26 22:05:58 UTC) #3
Siggi Cherem (dart-lang)
(tbr)
5 years, 4 months ago (2015-03-26 22:06:08 UTC) #4
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 20ebdd74e145f880dfbbca44a2b84c162023db4a (presubmit successful).
5 years, 4 months ago (2015-03-26 22:06:22 UTC) #5
nweiz
On 2015/03/26 22:06:22, Siggi Cherem (dart-lang) wrote: > Committed patchset #1 (id:1) manually as > ...
5 years, 4 months ago (2015-03-26 22:06:35 UTC) #6
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-03-26 22:07:03 UTC) #7
Message was sent while issue was closed.
On 2015/03/26 22:06:08, Siggi Cherem (dart-lang) wrote:
> (tbr)

I just about to submit just to keep bots happy :)

thanks for the quick reply

Powered by Google App Engine
This is Rietveld 408576698