Issue 103303005: Revert "Implement Element.matches(selectors)"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 103303005: Revert "Implement Element.matches(selectors)" (Closed)

Created:
7 years ago by adamk

Modified:
7 years ago

Reviewers:
philipj_slow

CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Implement Element.matches(selectors)" This reverts commit 23ee357add9601e5d28329e927acbaeab0ddcd7e. It was causing failures on linux_chromeos browser_tests, in particular VirtualKeyboardBrowserTest.*. BUG=326652 TBR=philipj@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163457

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -46 lines)			Patch
D	LayoutTests/fast/dom/Element/matches.html	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	LayoutTests/fast/dom/Element/matches-expected.txt	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	Source/core/dom/Element.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	Source/core/dom/Element.idl	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r163457 (presubmit successful).

Expand Messages | Collapse Messages