Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1033013003: Refactor http cache removing from a StoragePartition into separate class: (Closed)

Created:
5 years, 9 months ago by lazyboy
Modified:
5 years, 9 months ago
Reviewers:
Mike West
CC:
chromium-reviews, gavinp+disk_chromium.org, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor http cache removing from a StoragePartition into separate class: StoragePartitionHttpCacheDataRemover. This will enable us to to clear http cache from a StoragePartition from chrome/ layer. <webview>s with their own storage partitions can use this to clear patitions' cache. This will be used to implement clear cache for <webview>, complete CL is: https://chromiumcodereview.appspot.com/1021073002/ BUG=406437 Test=None, internal only change. Committed: https://crrev.com/044f3ca9e0eb0dc89ed529ef1fd7c0d20534b95d Cr-Commit-Position: refs/heads/master@{#322428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -142 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.h View 5 chunks +0 lines, -34 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 5 chunks +8 lines, -108 lines 0 comments Download
A chrome/browser/browsing_data/storage_partition_http_cache_data_remover.h View 1 chunk +78 lines, -0 lines 0 comments Download
A chrome/browser/browsing_data/storage_partition_http_cache_data_remover.cc View 1 chunk +156 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lazyboy
FYI, refactored from https://chromiumcodereview.appspot.com/1021073002/
5 years, 9 months ago (2015-03-26 16:33:09 UTC) #2
Mike West
LGTM, assuming the bots are happy.
5 years, 9 months ago (2015-03-26 16:37:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033013003/1
5 years, 9 months ago (2015-03-26 18:18:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 18:22:41 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 18:23:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/044f3ca9e0eb0dc89ed529ef1fd7c0d20534b95d
Cr-Commit-Position: refs/heads/master@{#322428}

Powered by Google App Engine
This is Rietveld 408576698