Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1032953002: Refactored the test WebRtcBrowserTest.CanForwardRemoteStream (Closed)

Created:
5 years, 9 months ago by perkj_chrome
Modified:
5 years, 9 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactored the test WebRtcBrowserTest.CanForwardRemoteStream This test now only use 2 peerconnections. Furthermore, it only creates one mediastream that is sent from pc1 to pc2. When the stream is playing on pc2, it is cloned and sent back to pc1. The purpose of this refactoring is no reduce the CPU requirement and the number of streams sent to fix flakiness problems. This cl removes the test CanForwardRemoteStream720 since it test the same thing as CanForwardRemoteStream but with a higher video resolution. BUG=469819 Committed: https://crrev.com/a3cde69715119e41a051cf62eb2cb799121cc8cb Cr-Commit-Position: refs/heads/master@{#322362}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix nits and enabled on tsan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -66 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 2 chunks +5 lines, -30 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 1 chunk +14 lines, -36 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
perkj_chrome
Can you please review?
5 years, 9 months ago (2015-03-26 09:33:06 UTC) #2
phoglund_chromium
lgtm https://codereview.chromium.org/1032953002/diff/1/content/test/data/media/peerconnection-call.html File content/test/data/media/peerconnection-call.html (right): https://codereview.chromium.org/1032953002/diff/1/content/test/data/media/peerconnection-call.html#newcode161 content/test/data/media/peerconnection-call.html:161: // The stream sent from pc1 to pc2 ...
5 years, 9 months ago (2015-03-26 09:59:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032953002/20001
5 years, 9 months ago (2015-03-26 11:09:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 12:07:31 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 12:08:06 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a3cde69715119e41a051cf62eb2cb799121cc8cb
Cr-Commit-Position: refs/heads/master@{#322362}

Powered by Google App Engine
This is Rietveld 408576698