Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 103293006: Remove outdated profiler flags (Closed)

Created:
7 years ago by Jakob Kummerow
Modified:
7 years ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 : remove --direct-self-opt #

Patch Set 2 : remove --watch-ic-patching #

Patch Set 3 : remove --retry-self-opt #

Patch Set 4 : remove --self-optimization #

Patch Set 5 : remove --interrupt-at-exit #

Patch Set 6 : remove --weighted-back-edges #

Total comments: 2

Patch Set 7 : remove moar stuffs (per review feedback) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -399 lines) Patch
M src/api.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 4 5 3 chunks +21 lines, -36 lines 0 comments Download
M src/compiler.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 2 chunks +1 line, -19 lines 0 comments Download
M src/heap.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 5 3 chunks +21 lines, -35 lines 0 comments Download
M src/ic.cc View 1 2 chunks +2 lines, -7 lines 0 comments Download
M src/isolate.cc View 1 2 3 4 5 6 2 chunks +0 lines, -2 lines 0 comments Download
M src/mark-compact.cc View 1 2 chunks +0 lines, -11 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 3 4 5 3 chunks +21 lines, -36 lines 0 comments Download
M src/runtime-profiler.h View 1 2 3 4 5 6 1 chunk +0 lines, -29 lines 0 comments Download
M src/runtime-profiler.cc View 1 2 3 4 5 6 5 chunks +26 lines, -183 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 5 3 chunks +21 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jakob Kummerow
Clean up ALL the cruft!
7 years ago (2013-12-05 12:18:09 UTC) #1
Yang
LGTM! this is awesome. https://codereview.chromium.org/103293006/diff/120001/src/runtime-profiler.h File src/runtime-profiler.h (right): https://codereview.chromium.org/103293006/diff/120001/src/runtime-profiler.h#newcode64 src/runtime-profiler.h:64: bool code_generated_; This seems to ...
7 years ago (2013-12-05 12:26:59 UTC) #2
Jakob Kummerow
https://codereview.chromium.org/103293006/diff/120001/src/runtime-profiler.h File src/runtime-profiler.h (right): https://codereview.chromium.org/103293006/diff/120001/src/runtime-profiler.h#newcode64 src/runtime-profiler.h:64: bool code_generated_; On 2013/12/05 12:26:59, Yang wrote: > This ...
7 years ago (2013-12-05 12:31:51 UTC) #3
Yang
On 2013/12/05 12:31:51, Jakob wrote: > https://codereview.chromium.org/103293006/diff/120001/src/runtime-profiler.h > File src/runtime-profiler.h (right): > > https://codereview.chromium.org/103293006/diff/120001/src/runtime-profiler.h#newcode64 > ...
7 years ago (2013-12-05 12:33:24 UTC) #4
Jakob Kummerow
7 years ago (2013-12-06 09:52:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #7 manually as r18266.

Powered by Google App Engine
This is Rietveld 408576698