Issue 1032923002: Suppress our one pixel test on mac since it diffs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1032923002: Suppress our one pixel test on mac since it diffs (Closed)

Created:
5 years, 9 months ago by Tom Sepez

Modified:
5 years, 9 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Suppress our "pixel" test on mac since it diffs. This involves bringing some of the suppressions file mechanism into run_pixel_tests.py (making a common module would be a nice follow-up) R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6546e49b66848f3a3f28ef5cfa7420cd03cb4368

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	M	testing/SUPPRESSIONS_mac	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	testing/tools/run_pixel_tests.py	View		3 chunks	+30 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 9 months ago (2015-03-25 21:30:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6546e49b66848f3a3f28ef5cfa7420cd03cb4368 (presubmit successful).