Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1032903002: Unify various QUIC server classes in net/quic and net/tools/quic. (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify various QUIC server classes in net/quic and net/tools/quic. Leaving the QuicDispatcher unchanged for now. Will unify that in a followup. Also removes the remaining balsa dependency in QuicInMemoryCache. Committed: https://crrev.com/0e9454716882c46f319ab5aa6f6987b163813b29 Cr-Commit-Position: refs/heads/master@{#322387}

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Rebase #

Patch Set 4 : fix build issues #

Patch Set 5 : fix build issues #

Patch Set 6 : Fix iOS #

Patch Set 7 : Fix Windows issues #

Patch Set 8 : maybe fix Android #

Patch Set 9 : doh #

Patch Set 10 : Fix another Windows issues #

Patch Set 11 : Fix Windows one more issue #

Patch Set 12 : I hate windows #

Patch Set 13 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -790 lines) Patch
M net/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +11 lines, -17 lines 0 comments Download
M net/net.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +10 lines, -16 lines 0 comments Download
M net/quic/quic_dispatcher.h View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
D net/quic/quic_in_memory_cache.h View 1 chunk +0 lines, -114 lines 0 comments Download
D net/quic/quic_in_memory_cache.cc View 1 chunk +0 lines, -183 lines 0 comments Download
M net/quic/quic_server.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M net/quic/quic_server_bin.cc View 3 chunks +6 lines, -6 lines 0 comments Download
D net/quic/quic_server_session.h View 1 chunk +0 lines, -119 lines 0 comments Download
D net/quic/quic_spdy_server_stream.h View 1 chunk +0 lines, -66 lines 0 comments Download
D net/quic/quic_spdy_server_stream.cc View 1 chunk +0 lines, -163 lines 0 comments Download
M net/spdy/spdy_http_utils.h View 2 chunks +6 lines, -6 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +44 lines, -83 lines 0 comments Download

Messages

Total messages: 62 (35 generated)
Ryan Hamilton
5 years, 9 months ago (2015-03-25 18:33:52 UTC) #2
ramant (doing other things)
lgtm Very cool.
5 years, 9 months ago (2015-03-25 19:18:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/20001
5 years, 9 months ago (2015-03-25 20:53:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/8618) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-25 20:59:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/40001
5 years, 9 months ago (2015-03-25 21:09:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/8629)
5 years, 9 months ago (2015-03-25 21:14:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/80001
5 years, 9 months ago (2015-03-25 22:07:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/8673)
5 years, 9 months ago (2015-03-25 22:15:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/100001
5 years, 9 months ago (2015-03-25 22:33:22 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/60031)
5 years, 9 months ago (2015-03-25 23:01:46 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/120001
5 years, 9 months ago (2015-03-25 23:20:46 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/140001
5 years, 9 months ago (2015-03-25 23:28:35 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/8721) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-25 23:33:21 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/160001
5 years, 9 months ago (2015-03-25 23:37:06 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/67657)
5 years, 9 months ago (2015-03-26 00:25:29 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/180001
5 years, 9 months ago (2015-03-26 00:28:54 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/40456)
5 years, 9 months ago (2015-03-26 01:55:57 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/200001
5 years, 9 months ago (2015-03-26 02:28:00 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/40497)
5 years, 9 months ago (2015-03-26 03:48:13 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/200001
5 years, 9 months ago (2015-03-26 04:02:48 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/220001
5 years, 9 months ago (2015-03-26 04:36:53 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/48982)
5 years, 9 months ago (2015-03-26 05:25:14 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/220001
5 years, 9 months ago (2015-03-26 13:36:07 UTC) #55
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/49073)
5 years, 9 months ago (2015-03-26 13:40:26 UTC) #57
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032903002/240001
5 years, 9 months ago (2015-03-26 14:13:38 UTC) #60
commit-bot: I haz the power
Committed patchset #13 (id:240001)
5 years, 9 months ago (2015-03-26 15:19:34 UTC) #61
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 15:20:34 UTC) #62
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/0e9454716882c46f319ab5aa6f6987b163813b29
Cr-Commit-Position: refs/heads/master@{#322387}

Powered by Google App Engine
This is Rietveld 408576698