Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1032843002: VectorICs: Address test-heap TODOS (Closed)

Created:
5 years, 9 months ago by mvstanton
Modified:
5 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: Address test-heap TODOS Tests for non-clearing of weak cells in LoadICs weren't running when vector ICs are enabled. R=ulan@chromium.org BUG= Committed: https://crrev.com/d1478f4e4f7c001d1e2b2846bc5d27a3f20d4cd7 Cr-Commit-Position: refs/heads/master@{#27435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M test/cctest/test-heap.cc View 3 chunks +26 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mvstanton
Hi Ulan, can you have a look? thanks! --Michael
5 years, 9 months ago (2015-03-25 10:42:39 UTC) #1
ulan
lgtm
5 years, 9 months ago (2015-03-25 10:53:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032843002/1
5 years, 9 months ago (2015-03-25 10:54:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 11:15:19 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 11:15:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1478f4e4f7c001d1e2b2846bc5d27a3f20d4cd7
Cr-Commit-Position: refs/heads/master@{#27435}

Powered by Google App Engine
This is Rietveld 408576698