Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1032833002: Reland "Filter invalid slots out from the SlotsBuffer after marking." (Closed)

Created:
5 years, 9 months ago by ulan
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Filter invalid slots out from the SlotsBuffer after marking." > There are two reasons that could cause invalid slots appearance in SlotsBuffer: > 1) If GC trims "tail" of an array for which it has already recorded a slots and then migrate another object to the "tail". > 2) Tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > This CL also adds useful machinery that helps triggering incremental write barriers. > BUG=chromium:454297 > LOG=Y NOTRY=true Committed: https://crrev.com/f86aadd1d45c756467dff8e08a055b462d7a060b Cr-Commit-Position: refs/heads/master@{#27433}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+404 lines, -32 lines) Patch
M src/flag-definitions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 1 3 chunks +14 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 9 chunks +157 lines, -22 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/store-buffer.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +213 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
PTAL. The original CL: https://codereview.chromium.org/1010363005
5 years, 9 months ago (2015-03-25 08:50:25 UTC) #2
Michael Achenbach
lgtm
5 years, 9 months ago (2015-03-25 08:52:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032833002/2
5 years, 9 months ago (2015-03-25 08:52:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:2)
5 years, 9 months ago (2015-03-25 08:52:56 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f86aadd1d45c756467dff8e08a055b462d7a060b Cr-Commit-Position: refs/heads/master@{#27433}
5 years, 9 months ago (2015-03-25 08:53:05 UTC) #7
Igor Sheludko
5 years, 9 months ago (2015-03-27 06:50:38 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:2) has been created in
https://codereview.chromium.org/1041593002/ by ishell@chromium.org.

The reason for reverting is: Reverting risky GC changes that block v8 roll..

Powered by Google App Engine
This is Rietveld 408576698