chrome/common/chrome_utility_messages.h - Issue 103283003: Media Galleries API Metadata: SafeMediaMetadataParser and IPCTunnelDataReader.

Unified Diff: chrome/common/chrome_utility_messages.h

Issue 103283003: Media Galleries API Metadata: SafeMediaMetadataParser and IPCTunnelDataReader. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix ownership issues Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc ('K') | « chrome/chrome_browser.gypi ('k') | chrome/utility/chrome_content_utility_client.h » ('j') | chrome/utility/chrome_content_utility_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/chrome_utility_messages.h

diff --git a/chrome/common/chrome_utility_messages.h b/chrome/common/chrome_utility_messages.h

index 1e63b12f46e0f0e78580f857d1c29bb993564df0..88870a555dad062de83368863b52805fc0afdec8 100644

--- a/chrome/common/chrome_utility_messages.h

+++ b/chrome/common/chrome_utility_messages.h

@@ -227,6 +227,16 @@ IPC_MESSAGE_CONTROL2(ChromeUtilityMsg_IndexPicasaAlbumsContents,

IPC_MESSAGE_CONTROL2(ChromeUtilityMsg_CheckMediaFile,

int64 /* milliseconds_of_decoding */,

IPC::PlatformFileForTransit /* Media file to parse */)

+IPC_MESSAGE_CONTROL2(

+ ChromeUtilityMsg_ParseMediaMetadata,

+ std::string /* mime_type */,

+ int64 /* total_size */)

+IPC_MESSAGE_CONTROL2(

+ ChromeUtilityMsg_ParseMediaMetadata_RequestBlobBytes_Finished,

+ int64 /* request_id */,

+ std::string /* bytes */)

vandebo (ex-Chrome) 2014/01/07 18:34:59 Maybe this should be char* instead of std::string?

tommycli 2014/01/07 20:23:31 I don't see any other pointers in IPC messages. I

vandebo (ex-Chrome) 2014/01/08 00:26:18 I think it's preferred to pass std::vector<unsigne

tommycli 2014/01/08 01:17:10 Done.

#endif // !defined(OS_ANDROID) && !defined(OS_IOS)

//------------------------------------------------------------------------------

@@ -372,4 +382,15 @@ IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_IndexPicasaAlbumsContents_Finished,

// the file appears to be a well formed media file.

IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_CheckMediaFile_Finished,

bool /* passed_checks */)

+IPC_MESSAGE_CONTROL2(

+ ChromeUtilityHostMsg_ParseMediaMetadata_Finished,

+ bool /* parse_success */,

+ base::DictionaryValue /* metadata */)

+IPC_MESSAGE_CONTROL3(

+ ChromeUtilityHostMsg_ParseMediaMetadata_RequestBlobBytes,

+ int64 /* request_id */,

+ int64 /* start_byte */,

+ int64 /* length */)

#endif // !defined(OS_ANDROID) && !defined(OS_IOS)