Modify ListContainer<T>::Allocate to return a pointer of type void*.

Modify ListContainer<T>::Allocate to return a pointer of type void*.

This saves a cast and makes this code
-fsanitize=cfi-unrelated-cast clean.

BUG=457523
R=danakj@chromium.org,weiliangc@chromium.org

Committed: https://crrev.com/cc2851be231f7fbcc7c4cb9ab14c20c7d235acb2
Cr-Commit-Position: refs/heads/master@{#322231}

[weiliangc, 2015-03-25 15:14:42]

LGTM

[danakj, 2015-03-25 16:17:53]

LGTM

[danakj, 2015-03-25 16:18:21]

I don't understand what this -fsanitize=cfi-unrelated-cast is or why this is a
problem to fix though.

[pcc1, 2015-03-25 18:54:00]

On 2015/03/25 16:18:21, danakj wrote:
> I don't understand what this -fsanitize=cfi-unrelated-cast is or why this is a
> problem to fix though.

-fsanitize=cfi-unrelated-cast is one form of bad cast checking that we're
working on deploying. I've added a link to the bug description which should
hopefully help explain this.

[pcc1, 2015-03-25 18:54:06]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2015-03-25 18:54:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1032803002/1

[danakj, 2015-03-25 18:57:21]

On Wed, Mar 25, 2015 at 11:54 AM, <pcc@chromium.org> wrote:

> On 2015/03/25 16:18:21, danakj wrote:
>
>> I don't understand what this -fsanitize=cfi-unrelated-cast is or why this
>> is a
>> problem to fix though.
>>
>
> -fsanitize=cfi-unrelated-cast is one form of bad cast checking that we're
> working on deploying. I've added a link to the bug description which should
> hopefully help explain this.
>

But what was bad about this cast?

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-03-25 20:28:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-25 20:29:34]

Patchset 1 (id:??) landed as
https://crrev.com/cc2851be231f7fbcc7c4cb9ab14c20c7d235acb2
Cr-Commit-Position: refs/heads/master@{#322231}