Adds ui_test_pak to html_viewer's deps

Adds ui_test_pak to html_viewer's deps

We currently need it, so we should have a dependency on it.

R=erg@chromium.org

Committed: https://crrev.com/8185a19dabb74722ada9cb5bb4ba820a6053a522
Cr-Commit-Position: refs/heads/master@{#322103}

[Elliot Glaysher, 2015-03-24 20:27:18]

lgtm

Is this all that you need to do to fix the first gyp build in the
html_viewer build instructions?

On Tue, Mar 24, 2015 at 1:02 PM, <sky@chromium.org> wrote:

> Reviewers: Elliot Glaysher,
>
> Description:
> Adds ui_test_pak to html_viewer's deps
>
> We currently need it, so we should have a dependency on it.
>
> R=erg@chromium.org
>
> Please review this at https://codereview.chromium.org/1032733002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+1, -0 lines):
>   M mojo/services/html_viewer/BUILD.gn
>
>
> Index: mojo/services/html_viewer/BUILD.gn
> diff --git a/mojo/services/html_viewer/BUILD.gn
> b/mojo/services/html_viewer/BUILD.gn
> index c609bb5e169066002b63a9c3b6563cf00c48ce79..
> b776d38a8c6f5e7065e52b1f367737533f632f7e 100644
> --- a/mojo/services/html_viewer/BUILD.gn
> +++ b/mojo/services/html_viewer/BUILD.gn
> @@ -102,6 +102,7 @@ source_set("lib") {
>      "//third_party/mojo_services/src/surfaces/public/interfaces",
>      "//ui/gfx/geometry",
>      "//ui/native_theme",
> +    "//ui/resources:ui_test_pak",
>      "//url",
>    ]
>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2015-03-24 20:27:36]

I believe so.

On Tue, Mar 24, 2015 at 1:27 PM, Elliot Glaysher (Chromium)
<erg@chromium.org> wrote:
> lgtm
>
> Is this all that you need to do to fix the first gyp build in the
> html_viewer build instructions?
>
> On Tue, Mar 24, 2015 at 1:02 PM, <sky@chromium.org> wrote:
>>
>> Reviewers: Elliot Glaysher,
>>
>> Description:
>> Adds ui_test_pak to html_viewer's deps
>>
>> We currently need it, so we should have a dependency on it.
>>
>> R=erg@chromium.org
>>
>> Please review this at https://codereview.chromium.org/1032733002/
>>
>> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>>
>> Affected files (+1, -0 lines):
>>   M mojo/services/html_viewer/BUILD.gn
>>
>>
>> Index: mojo/services/html_viewer/BUILD.gn
>> diff --git a/mojo/services/html_viewer/BUILD.gn
>> b/mojo/services/html_viewer/BUILD.gn
>> index
>>
c609bb5e169066002b63a9c3b6563cf00c48ce79..b776d38a8c6f5e7065e52b1f367737533f632f7e
>> 100644
>> --- a/mojo/services/html_viewer/BUILD.gn
>> +++ b/mojo/services/html_viewer/BUILD.gn
>> @@ -102,6 +102,7 @@ source_set("lib") {
>>      "//third_party/mojo_services/src/surfaces/public/interfaces",
>>      "//ui/gfx/geometry",
>>      "//ui/native_theme",
>> +    "//ui/resources:ui_test_pak",
>>      "//url",
>>    ]
>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Elliot Glaysher, 2015-03-24 20:29:46]

lgtm

[sky, 2015-03-24 23:38:06]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2015-03-24 23:39:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1032733002/1

[commit-bot: I haz the power, 2015-03-25 00:28:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-25 00:29:06]

Patchset 1 (id:??) landed as
https://crrev.com/8185a19dabb74722ada9cb5bb4ba820a6053a522
Cr-Commit-Position: refs/heads/master@{#322103}