Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: Source/core/css/CSSSegmentedFontFaceCache.h

Issue 103273002: CSSSegmentedFontFaceCache should not know about Document. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSFontSelector.cpp ('k') | Source/core/css/CSSSegmentedFontFaceCache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSSegmentedFontFaceCache.h
diff --git a/Source/core/css/CSSSegmentedFontFaceCache.h b/Source/core/css/CSSSegmentedFontFaceCache.h
index e753dd780989853f92a16f9a8d6c9ef815563588..c18220906eb1504d2dc597a50edfab215203376e 100644
--- a/Source/core/css/CSSSegmentedFontFaceCache.h
+++ b/Source/core/css/CSSSegmentedFontFaceCache.h
@@ -45,9 +45,11 @@ public:
// FIXME: Remove CSSFontSelector as argument. Passing CSSFontSelector here is
// a result of egregious spaghettification in CSSFontFace/FontFaceSet.
- void addFontFaceRule(CSSFontSelector*, const StyleRuleFontFace*);
- void removeFontFaceRule(const StyleRuleFontFace*);
- CSSSegmentedFontFace* getFontFace(const FontDescription&, const AtomicString& family);
+ void add(CSSFontSelector*, const StyleRuleFontFace*, PassRefPtr<CSSFontFace>);
+ void remove(const StyleRuleFontFace*);
+ // FIXME: It's sort of weird that add/remove uses StyleRuleFontFace* as key,
+ // but this function uses FontDescription/family pair.
+ CSSSegmentedFontFace* get(const FontDescription&, const AtomicString& family);
unsigned version() const { return m_version; }
« no previous file with comments | « Source/core/css/CSSFontSelector.cpp ('k') | Source/core/css/CSSSegmentedFontFaceCache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698