Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1032703002: Trace background/visibility events (Closed)

Created:
5 years, 9 months ago by jdduke (slow)
Modified:
5 years, 9 months ago
Reviewers:
no sievers
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trace background/visibility events Trace the following events: * CompositorImplAndroid::SetVisility * RenderWidgetHost::WasHidden * RenderWidgetHost::WasShown * RenderProcessHostImpl::SetBackgrounded These events give greater context to content behavior with respect to visibility changes. BUG=466213 Committed: https://crrev.com/76f34770c06ecb7ed15bfa0ff9078d25a1fdec29 Cr-Commit-Position: refs/heads/master@{#322306}

Patch Set 1 #

Total comments: 2

Patch Set 2 : renderer_host #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jdduke (slow)
sievers@: PTAL, thanks.
5 years, 9 months ago (2015-03-25 21:39:41 UTC) #2
no sievers
lgtm https://codereview.chromium.org/1032703002/diff/1/content/browser/renderer_host/render_widget_host_impl.cc File content/browser/renderer_host/render_widget_host_impl.cc (right): https://codereview.chromium.org/1032703002/diff/1/content/browser/renderer_host/render_widget_host_impl.cc#newcode514 content/browser/renderer_host/render_widget_host_impl.cc:514: TRACE_EVENT0("browser", "RenderWidgetHostImpl::WasHidden"); maybe this should be in the ...
5 years, 9 months ago (2015-03-25 21:56:10 UTC) #3
jdduke (slow)
https://codereview.chromium.org/1032703002/diff/1/content/browser/renderer_host/render_widget_host_impl.cc File content/browser/renderer_host/render_widget_host_impl.cc (right): https://codereview.chromium.org/1032703002/diff/1/content/browser/renderer_host/render_widget_host_impl.cc#newcode514 content/browser/renderer_host/render_widget_host_impl.cc:514: TRACE_EVENT0("browser", "RenderWidgetHostImpl::WasHidden"); On 2015/03/25 21:56:10, sievers wrote: > maybe ...
5 years, 9 months ago (2015-03-25 22:19:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032703002/20001
5 years, 9 months ago (2015-03-25 22:21:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/47449)
5 years, 9 months ago (2015-03-25 23:49:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032703002/20001
5 years, 9 months ago (2015-03-25 23:56:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 03:45:04 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 03:45:41 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76f34770c06ecb7ed15bfa0ff9078d25a1fdec29
Cr-Commit-Position: refs/heads/master@{#322306}

Powered by Google App Engine
This is Rietveld 408576698