components/favicon_base/BUILD.gn - Issue 1032683002: [Icons NTP] Refactoring: Moving FallbackIconService to components\favicon\core

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon_base/BUILD.gn

Issue 1032683002: [Icons NTP] Refactoring: Moving FallbackIconService to components\favicon\core (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Putting back +third_party/skia/include for favicon_base DEPS. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/favicon_base/BUILD.gn

diff --git a/components/favicon_base/BUILD.gn b/components/favicon_base/BUILD.gn

index 07daa0abe360232514b36eb0e9609e305584a7d3..2fcfb9c45027f22069822134e802cc0201a20147 100644

--- a/components/favicon_base/BUILD.gn

+++ b/components/favicon_base/BUILD.gn

@@ -4,8 +4,6 @@

source_set("favicon_base") {

sources = [

- "fallback_icon_service.cc",

- "fallback_icon_service.h",

"fallback_icon_style.cc",

"fallback_icon_style.h",

"favicon_callback.h",

« components/favicon/core/DEPS ('K') | « components/favicon_base.gypi ('k') | components/favicon_base/DEPS » ('j') | no next file with comments »