Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: components/favicon/core/fallback_icon_service.h

Issue 1032683002: [Icons NTP] Refactoring: Moving FallbackIconService to components\favicon\core (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Putting back +third_party/skia/include for favicon_base DEPS. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/fallback_icon_service.h
diff --git a/components/favicon_base/fallback_icon_service.h b/components/favicon/core/fallback_icon_service.h
similarity index 78%
rename from components/favicon_base/fallback_icon_service.h
rename to components/favicon/core/fallback_icon_service.h
index cc98adfe20feb677029bfa6c6cd3b010f38045c3..9b3f6ba10a028a1669daf0a14ea1a90c9d6a7937 100644
--- a/components/favicon_base/fallback_icon_service.h
+++ b/components/favicon/core/fallback_icon_service.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_FAVICON_BASE_FALLBACK_ICON_SERVICE_H_
-#define COMPONENTS_FAVICON_BASE_FALLBACK_ICON_SERVICE_H_
+#ifndef COMPONENTS_FAVICON_CORE_FALLBACK_ICON_SERVICE_H_
+#define COMPONENTS_FAVICON_CORE_FALLBACK_ICON_SERVICE_H_
#include <string>
#include <vector>
@@ -17,8 +17,8 @@ class Canvas;
}
namespace favicon_base {
-
struct FallbackIconStyle;
+}
// A service to provide methods to render fallback favicons.
class FallbackIconService {
@@ -31,14 +31,14 @@ class FallbackIconService {
std::vector<unsigned char> RenderFallbackIconBitmap(
const GURL& icon_url,
int size,
- const FallbackIconStyle& style);
+ const favicon_base::FallbackIconStyle& style);
private:
// Renders a fallback icon on |canvas| at position (|x|, |y|). |size| is icon
// width and height in pixels.
void DrawFallbackIcon(const GURL& icon_url,
int size,
- const FallbackIconStyle& style,
+ const favicon_base::FallbackIconStyle& style,
gfx::Canvas* canvas);
std::vector<std::string> font_list_;
@@ -46,6 +46,4 @@ class FallbackIconService {
DISALLOW_COPY_AND_ASSIGN(FallbackIconService);
};
-} // namespace favicon_base
-
-#endif // COMPONENTS_FAVICON_BASE_FALLBACK_ICON_SERVICE_H_
+#endif // COMPONENTS_FAVICON_CORE_FALLBACK_ICON_SERVICE_H_

Powered by Google App Engine
This is Rietveld 408576698