components/favicon/core/BUILD.gn - Issue 1032683002: [Icons NTP] Refactoring: Moving FallbackIconService to components\favicon\core

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/favicon/core/BUILD.gn

Issue 1032683002: [Icons NTP] Refactoring: Moving FallbackIconService to components\favicon\core (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Putting back +third_party/skia/include for favicon_base DEPS. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 static_library("core") {	5 static_library("core") {

6 sources = [	6 sources = [

	7 "fallback_icon_service.cc",

	8 "fallback_icon_service.h",

7 "favicon_client.h",	9 "favicon_client.h",

8 "favicon_driver.h",	10 "favicon_driver.h",

9 "favicon_handler.cc",	11 "favicon_handler.cc",

10 "favicon_handler.h",	12 "favicon_handler.h",

11 "favicon_service.cc",	13 "favicon_service.cc",

12 "favicon_service.h",	14 "favicon_service.h",

13 "favicon_tab_helper_observer.h",	15 "favicon_tab_helper_observer.h",

14 "favicon_url.cc",	16 "favicon_url.cc",

15 "favicon_url.h",	17 "favicon_url.h",

16 ]	18 ]

17	19

18 deps = [	20 deps = [

19 "//components/bookmarks/browser",	21 "//components/bookmarks/browser",

20 "//components/favicon_base",	22 "//components/favicon_base",

21 "//components/history/core/browser",	23 "//components/history/core/browser",

22 "//components/keyed_service/core",	24 "//components/keyed_service/core",

23 "//skia",	25 "//skia",

24 "//ui/gfx",	26 "//ui/gfx",

25 "//url",	27 "//url",

26 ]	28 ]

27 }	29 }

OLD	NEW

« no previous file with comments | « components/favicon.gypi ('k') | components/favicon/core/DEPS » ('j') | components/favicon/core/DEPS » ('J')