Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: src/hydrogen.h

Issue 1032653002: Do not assign positions to parser-generated desugarings. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased for landing Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.h
diff --git a/src/hydrogen.h b/src/hydrogen.h
index f1a6aa1509f04078860bb38ee37e7d3f6da17304..268976af3ddb5416234e77dfe297fadcdfed6c25 100644
--- a/src/hydrogen.h
+++ b/src/hydrogen.h
@@ -1868,8 +1868,10 @@ class HGraphBuilder {
protected:
void SetSourcePosition(int position) {
- DCHECK(position != RelocInfo::kNoPosition);
- position_.set_position(position - start_position_);
+ if (position != RelocInfo::kNoPosition) {
+ position_.set_position(position - start_position_);
+ }
+ // Otherwise position remains unknown.
}
void EnterInlinedSource(int start_position, int id) {
« no previous file with comments | « no previous file | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698