Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1032623007: Remove v8::Isolate::ClearInterrupt (Closed)

Created:
5 years, 9 months ago by yurys
Modified:
5 years, 9 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove v8::Isolate::ClearInterrupt The method was deprecated a while ago: https://crrev.com/87e4bba31eabfd3b12e42b5886dc9da08d2daf13 LOG=Y BUG=YES API=Remove v8::Isolate::ClearInterrupt Committed: https://crrev.com/a037a44582b83b0799d8580ab9c3aa8fd7ab3dd7 Cr-Commit-Position: refs/heads/master@{#27449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M include/v8.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
yurys
5 years, 9 months ago (2015-03-25 13:57:16 UTC) #2
alph
lgtm
5 years, 9 months ago (2015-03-25 14:11:59 UTC) #3
yurys
@jochen: please do OWNERS review
5 years, 9 months ago (2015-03-25 14:24:20 UTC) #4
Yang
On 2015/03/25 14:24:20, yurys wrote: > @jochen: please do OWNERS review drive-by lgtm.
5 years, 9 months ago (2015-03-25 14:27:01 UTC) #5
yurys
On 2015/03/25 14:27:01, Yang wrote: > On 2015/03/25 14:24:20, yurys wrote: > > @jochen: please ...
5 years, 9 months ago (2015-03-25 14:51:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032623007/1
5 years, 9 months ago (2015-03-25 14:51:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 15:32:10 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 15:32:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a037a44582b83b0799d8580ab9c3aa8fd7ab3dd7
Cr-Commit-Position: refs/heads/master@{#27449}

Powered by Google App Engine
This is Rietveld 408576698