Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 1032623003: Test for wrong arguments object materialization. (Closed)

Created:
5 years, 9 months ago by Jarin
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Test for wrong arguments object materialization. The test demonstrates a bad interaction between arguments object materialization, escape analysis and exception handling. We can return a wrong arguments object if we materialize arguments object (using f.arguments) and then throw around f's frame so that f does not clean up the materialized frame information (see the MaterializedObjectStore in deoptimizer.h/.cc). If we enter another function that has the same frame pointer and request an arguments object of (or lazily deoptimize) that function, we can get the materialized object of the original function. We should clean up the materialized object store when we unwind the stack. BUG=v8:3985 LOG=n Committed: https://crrev.com/0f94c96cbcdc8147ee2951ad162184fe44bffd4e Cr-Commit-Position: refs/heads/master@{#27406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-3985.js View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years, 9 months ago (2015-03-24 12:56:19 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-24 13:00:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032623003/1
5 years, 9 months ago (2015-03-24 13:01:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 13:20:16 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 13:20:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f94c96cbcdc8147ee2951ad162184fe44bffd4e
Cr-Commit-Position: refs/heads/master@{#27406}

Powered by Google App Engine
This is Rietveld 408576698