Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1032603005: Factor out glyph position computations in SVGTextQuery (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Factor out glyph position computations in SVGTextQuery In preparation for fixing RTL handling, move some common code for computing the position of a glyph into two helper functions. No functional changes. BUG=470326 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M Source/core/layout/svg/SVGTextQuery.cpp View 4 chunks +39 lines, -39 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 9 months ago (2015-03-26 15:49:42 UTC) #2
Erik Dahlström (inactive)
lgtm
5 years, 9 months ago (2015-03-26 16:21:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032603005/1
5 years, 9 months ago (2015-03-26 16:26:37 UTC) #5
pdr.
On 2015/03/26 at 16:26:37, commit-bot wrote: > CQ is trying da patch. Follow status at ...
5 years, 9 months ago (2015-03-26 17:36:44 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 19:38:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192624

Powered by Google App Engine
This is Rietveld 408576698