Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1032603004: Revert of Roll src/third_party/WebKit 698efc0:7d47c95 (svn 192500:192506) (Closed)

Created:
5 years, 9 months ago by pneubeck (no reviews)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, Julien - ping for review
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/WebKit 698efc0:7d47c95 (svn 192500:192506) (patchset #1 id:1 of https://codereview.chromium.org/1037703002/) Reason for revert: Broke compilation with GN: https://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/6697/steps/gn/logs/stdio caused by this Blink commit: https://chromium.googlesource.com/chromium/blink/+/7d47c95bc49510d29e36fc2895eef3e67706ef41 Original issue's description: > Roll src/third_party/WebKit 698efc0:7d47c95 (svn 192500:192506) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/698efc0..7d47c95 > > TBR=jchaffraix@chromium.org > > Committed: https://crrev.com/60a49fc315e7eaed780da86aad1eecd40f149f70 > Cr-Commit-Position: refs/heads/master@{#322139} TBR=jchaffraix@chromium.org,blink-deps-roller@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3e737f93c9f2e01d34bd64624b1672bff3ada233 Cr-Commit-Position: refs/heads/master@{#322154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
pneubeck (no reviews)
Created Revert of Roll src/third_party/WebKit 698efc0:7d47c95 (svn 192500:192506)
5 years, 9 months ago (2015-03-25 14:11:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032603004/1
5 years, 9 months ago (2015-03-25 14:11:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 14:12:38 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 14:13:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e737f93c9f2e01d34bd64624b1672bff3ada233
Cr-Commit-Position: refs/heads/master@{#322154}

Powered by Google App Engine
This is Rietveld 408576698