Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1032603003: Remove allow-insecure-websocket-from-https-origin flag (Closed)

Created:
5 years, 9 months ago by tyoshino (SeeGerritForStatus)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove allow-insecure-websocket-from-https-origin flag R=mkwst,jochen BUG=367149 Committed: https://crrev.com/c78545dbec6276a41f922d0f11c908fcd0d5789a Cr-Commit-Position: refs/heads/master@{#322748}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Mike West
LGTM, though you'll need a content/ OWNER. Isn't there an enterprise policy aspect to this ...
5 years, 9 months ago (2015-03-24 12:16:06 UTC) #2
tyoshino (SeeGerritForStatus)
On 2015/03/24 12:16:06, Mike West wrote: > LGTM, though you'll need a content/ OWNER. > ...
5 years, 9 months ago (2015-03-25 06:00:25 UTC) #3
tyoshino (SeeGerritForStatus)
+jochen
5 years, 9 months ago (2015-03-25 06:50:07 UTC) #5
jochen (gone - plz use gerrit)
let me have one roundtrip with security and enterprise before we proceed
5 years, 9 months ago (2015-03-25 12:21:07 UTC) #6
jochen (gone - plz use gerrit)
everybody's happy so lgtm
5 years, 9 months ago (2015-03-26 08:56:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032603003/20001
5 years, 8 months ago (2015-03-30 06:19:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-30 07:09:44 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 07:10:42 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c78545dbec6276a41f922d0f11c908fcd0d5789a
Cr-Commit-Position: refs/heads/master@{#322748}

Powered by Google App Engine
This is Rietveld 408576698