Don't show "requires Chrome restart" when toggling stats reporting on Mac OS X

chrome/browser/resources/options/browser_options.js

Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 8ba30db451adb4a6e9fa9894aecb30507daa4993..d45c42d76108c43a056b36a9ab9325987819a6fe 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -464,9 +464,16 @@ cr.define('options', function() {
         };
         // Attach the listener for updating the checkbox and restart button.
         var updateMetricsRestartButton = function() {
-          $('metrics-reporting-reset-restart').hidden =
-              loadTimeData.getBoolean('metricsReportingEnabledAtStart') ==
-                  $('metrics-reporting-enabled').checked;
+          if (cr.isMac) {
+            // A browser restart is never needed to toggle metrics reporting,
+            // and is only needed to toggle crash reporting when using Breakpad.
+            // Crashpad, used on Mac, does not require a browser restart.
+            $('metrics-reporting-reset-restart').hidden = true;
+          } else {

[Evan Stade, 2015/03/23 21:46:19]

I would make this function

if (cr.IsMac)
  return;

...

And put |hidden| in the html (the label should always start out hidden anyway,
so this should be reflected in the html).

In fact we don't need this helper function any more if we do this and move the
fn body into the onclick handler.

+            $('metrics-reporting-reset-restart').hidden =
+                loadTimeData.getBoolean('metricsReportingEnabledAtStart') ==
+                    $('metrics-reporting-enabled').checked;
+          }
         };
         $('metrics-reporting-enabled').onclick = function(event) {
           chrome.send('metricsReportingCheckboxChanged',