Don't show "requires Chrome restart" when toggling stats reporting on Mac OS X

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.exportPath('options');
 
 /**
  * @typedef {{actionLinkText: (string|undefined),
  *            childUser: (boolean|undefined),
  *            hasError: (boolean|undefined),
@@ skipping 446 matching lines @@
         var restartElements =
             $('metrics-reporting-reset-restart').querySelectorAll('*');
         for (var i = 0; i < restartTextFragments.length; i++) {
           restartElements[i].textContent = restartTextFragments[i];
         }
         restartElements[1].onclick = function(event) {
           chrome.send('restartBrowser');
         };
         // Attach the listener for updating the checkbox and restart button.
         var updateMetricsRestartButton = function() {
-          $('metrics-reporting-reset-restart').hidden =
-              loadTimeData.getBoolean('metricsReportingEnabledAtStart') ==
-                  $('metrics-reporting-enabled').checked;
+          if (cr.isMac) {
+            // A browser restart is never needed to toggle metrics reporting,
+            // and is only needed to toggle crash reporting when using Breakpad.
+            // Crashpad, used on Mac, does not require a browser restart.
+            $('metrics-reporting-reset-restart').hidden = true;
+          } else {

[Evan Stade, 2015/03/23 21:46:19]

I would make this function

if (cr.IsMac)
  return;

...

And put |hidden| in the html (the label should always start out hidden anyway,
so this should be reflected in the html).

In fact we don't need this helper function any more if we do this and move the
fn body into the onclick handler.

+            $('metrics-reporting-reset-restart').hidden =
+                loadTimeData.getBoolean('metricsReportingEnabledAtStart') ==
+                    $('metrics-reporting-enabled').checked;
+          }
         };
         $('metrics-reporting-enabled').onclick = function(event) {
           chrome.send('metricsReportingCheckboxChanged',
               [Boolean(event.currentTarget.checked)]);
           updateMetricsRestartButton();
         };
         $('metrics-reporting-enabled').checked =
             loadTimeData.getBoolean('metricsReportingEnabledAtStart');
         updateMetricsRestartButton();
       }
@@ skipping 1786 matching lines @@
       }
       button.textContent = loadTimeData.getString(strId);
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });