Don't show "requires Chrome restart" when toggling stats reporting on Mac OS X

Don't show "requires Chrome restart" when toggling stats reporting
preference on Mac OS X.

Metrics (UMA) never requires a restart for a toggle to take effect.  For
crash reporting, Breakpad required a restart, but Crashpad does not.  A
toggled preference takes effect immediately. Chrome on Mac OS X is now
using the crash reporting client from Crashpad, not Breakpad.

Since it is incorrect to state that a Chrome restart is required for a
change in this preference to take effect, remove the text and the link
that performs the restart.

BUG=466964
R=estade@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/8e57e5ba56c6514656530c22ff9f2aae50ce96b3

[Mark Mentovai, 2015-03-23 21:12:47]

mark@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2015-03-23 21:46:19]

https://codereview.chromium.org/1032573002/diff/1/chrome/browser/resources/op...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/1032573002/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/browser_options.js:472: } else {
I would make this function

if (cr.IsMac)
  return;

...

And put |hidden| in the html (the label should always start out hidden anyway,
so this should be reflected in the html).

In fact we don't need this helper function any more if we do this and move the
fn body into the onclick handler.

[Mark Mentovai, 2015-03-23 23:02:14]

Thanks, Evan. Updated.

[Evan Stade, 2015-03-23 23:44:39]

lgtm

[commit-bot: I haz the power, 2015-03-24 01:33:22]

Patchset 2 (id:??) landed as
https://crrev.com/8e57e5ba56c6514656530c22ff9f2aae50ce96b3
Cr-Commit-Position: refs/heads/master@{#321917}

[Mark Mentovai, 2015-03-24 01:33:33]

Committed patchset #2 (id:20001) manually as
8e57e5ba56c6514656530c22ff9f2aae50ce96b3 (presubmit successful).