Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1032563002: libusb: Fix composite_close to close HID handles as well. (Closed)

Created:
5 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libusb: Fix composite_close to close HID handles as well. When opening a composite device some combination of the WinUSB and HID APIs may be used. This patch fixes composite_close to close both WinUSB file handles and HID file handles. BUG=466578 Committed: https://crrev.com/e56e8ef67c39f1a6ea256939ec8f6f5ee82e59cf Cr-Commit-Position: refs/heads/master@{#321881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M third_party/libusb/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/libusb/composite-hid-close.patch View 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/libusb/src/libusb/os/windows_usb.c View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 9 months ago (2015-03-23 21:10:08 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 9 months ago (2015-03-23 22:37:36 UTC) #3
Ken Rockot(use gerrit already)
On 2015/03/23 22:37:36, Ken Rockot wrote: > lgtm also, yikes
5 years, 9 months ago (2015-03-23 22:37:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032563002/1
5 years, 9 months ago (2015-03-23 22:41:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 22:48:38 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 22:49:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e56e8ef67c39f1a6ea256939ec8f6f5ee82e59cf
Cr-Commit-Position: refs/heads/master@{#321881}

Powered by Google App Engine
This is Rietveld 408576698