Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1032553008: [Chromoting] Update client connection enums in JS to match C++. (Closed)

Created:
5 years, 9 months ago by garykac
Modified:
5 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Update client connection enums in JS to match C++. BUG= Committed: https://crrev.com/4cc79a20b0fe4b442265424dbdc2a5f4c36a2a25 Cr-Commit-Position: refs/heads/master@{#322249}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add support for AUTHENTICATED in webapp #

Total comments: 4

Patch Set 3 : Replace ClientSession.State.CREATED with INITIALIZING #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -19 lines) Patch
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/connection_to_host.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/crd/js/client_session.js View 1 2 3 chunks +18 lines, -10 lines 0 comments Download
M remoting/webapp/crd/js/log_to_server.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/webapp/crd/js/server_log_entry.js View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/webapp/crd/js/session_connector_impl.js View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
garykac
https://codereview.chromium.org/1032553008/diff/1/remoting/protocol/connection_to_host.h File remoting/protocol/connection_to_host.h (left): https://codereview.chromium.org/1032553008/diff/1/remoting/protocol/connection_to_host.h#oldcode37 remoting/protocol/connection_to_host.h:37: // enumeration in webapp/client_session.js and Path no longer valid. ...
5 years, 9 months ago (2015-03-24 20:09:14 UTC) #2
garykac
https://codereview.chromium.org/1032553008/diff/20001/remoting/webapp/crd/js/client_session.js File remoting/webapp/crd/js/client_session.js (right): https://codereview.chromium.org/1032553008/diff/20001/remoting/webapp/crd/js/client_session.js#newcode495 remoting/webapp/crd/js/client_session.js:495: oldState == remoting.ClientSession.State.AUTHENTICATED) { Currently, AUTHENTICATED is sent as ...
5 years, 9 months ago (2015-03-24 20:36:38 UTC) #3
Sergey Ulanov
lgtm https://codereview.chromium.org/1032553008/diff/20001/remoting/webapp/crd/js/client_session.js File remoting/webapp/crd/js/client_session.js (right): https://codereview.chromium.org/1032553008/diff/20001/remoting/webapp/crd/js/client_session.js#newcode112 remoting/webapp/crd/js/client_session.js:112: INITIALIZING: 1, The plugin never sends INITIALIZING state ...
5 years, 9 months ago (2015-03-25 00:01:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032553008/40001
5 years, 9 months ago (2015-03-25 21:23:13 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-25 22:25:41 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4cc79a20b0fe4b442265424dbdc2a5f4c36a2a25 Cr-Commit-Position: refs/heads/master@{#322249}
5 years, 9 months ago (2015-03-25 22:26:37 UTC) #9
garykac
5 years, 9 months ago (2015-03-26 19:03:48 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/1032553008/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/client_session.js (right):

https://codereview.chromium.org/1032553008/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/client_session.js:112: INITIALIZING: 1,
On 2015/03/25 00:01:49, Sergey Ulanov wrote:
> The plugin never sends INITIALIZING state notifications. It's the initial
state
> when ConnectionToHost is created, but the first state change notification is
> always for CONNECTING state. So it's equivalent to the CREATED state above. I
> suggest removing CREATED, and using INITIALIZING instead.

Done.

Powered by Google App Engine
This is Rietveld 408576698