Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1032533002: Add Media Router drop-down-button. (Closed)

Created:
5 years, 9 months ago by apacible
Modified:
5 years, 8 months ago
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Media Router drop-down-button. This custom polymer element is used as a button to toggle the cast-mode-player (hide/show). It is styled after the current cast extension's drop down button. BUG=464222 Committed: https://crrev.com/e908733bb3fa90e17924fe098bee3b9917db26ea Cr-Commit-Position: refs/heads/master@{#324149}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M chrome/browser/media_router_resources.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
apacible
PTAL, thanks! Screenshots: - default: https://screenshot.googleplex.com/rjhJOj67kv.png - hover: https://screenshot.googleplex.com/HWvjbEzJr2.png - showing: https://screenshot.googleplex.com/W4MitpLGsm.png
5 years, 8 months ago (2015-04-07 17:14:01 UTC) #9
James Hawkins
https://codereview.chromium.org/1032533002/diff/100001/chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css File chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css (right): https://codereview.chromium.org/1032533002/diff/100001/chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css#newcode6 chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css:6: background: white; Are you sure you want a white ...
5 years, 8 months ago (2015-04-07 17:16:10 UTC) #10
apacible
https://codereview.chromium.org/1032533002/diff/100001/chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css File chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css (right): https://codereview.chromium.org/1032533002/diff/100001/chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css#newcode6 chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css:6: background: white; On 2015/04/07 17:16:09, James Hawkins wrote: > ...
5 years, 8 months ago (2015-04-07 17:28:31 UTC) #11
Jeremy Klein
lgtm https://codereview.chromium.org/1032533002/diff/120001/chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css File chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css (right): https://codereview.chromium.org/1032533002/diff/120001/chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css#newcode17 chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css:17: float: right; optional nit: I have an irrational ...
5 years, 8 months ago (2015-04-07 17:32:21 UTC) #12
James Hawkins
lgtm
5 years, 8 months ago (2015-04-07 18:17:01 UTC) #13
apacible
https://codereview.chromium.org/1032533002/diff/120001/chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css File chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css (right): https://codereview.chromium.org/1032533002/diff/120001/chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css#newcode17 chrome/browser/resources/media_router/elements/drop_down_button/drop_down_button.css:17: float: right; On 2015/04/07 17:32:20, Jeremy Klein wrote: > ...
5 years, 8 months ago (2015-04-07 20:23:10 UTC) #14
mark a. foltz
lgtm
5 years, 8 months ago (2015-04-07 21:56:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032533002/140001
5 years, 8 months ago (2015-04-07 22:13:29 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:140001)
5 years, 8 months ago (2015-04-07 23:14:33 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 23:15:15 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e908733bb3fa90e17924fe098bee3b9917db26ea
Cr-Commit-Position: refs/heads/master@{#324149}

Powered by Google App Engine
This is Rietveld 408576698