Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 103253003: Prevent upscaling in desktop capture. (Closed)

Created:
7 years ago by hshi1
Modified:
7 years ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Prevent upscaling in desktop capture. The previous CL landed (r238359) is missing a size check to prevent upscaling in desktop capture. The correct logic should be to use native resolution if both maxWidth and maxHeight are no smaller than source dimensions, and to compute letterbox region if otherwise. BUG=324923 TEST=trybot, Chrome OS feedback screen captures in native resolution R=sergeyu@chromium.org TBR=wjia@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M content/browser/renderer_host/media/video_capture_device_impl.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hshi1
+sergeyu@ PTAL - sorry I have to re-open the bug because the CL I landed ...
7 years ago (2013-12-03 23:54:39 UTC) #1
Sergey Ulanov
lgtm
7 years ago (2013-12-04 01:08:32 UTC) #2
hshi1
7 years ago (2013-12-04 01:12:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r238514 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698