Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 103253002: Fix crash during build/gyp_chromium time. (Closed)

Created:
7 years ago by Nico
Modified:
7 years ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Fix crash during build/gyp_chromium time. Without GYP_DEFINES set, build/gyp_chromium would crash with Generating gyp files from GN... Traceback (most recent call last): File "./build/gyp_chromium", line 207, in <module> if not RunGN(supplemental_includes): File "./build/gyp_chromium", line 147, in RunGN gyp_vars = GetVarsStringForGN(supplemental_includes) File "./build/gyp_chromium", line 79, in GetVarsStringForGN items = shlex.split(env_string) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 279, in split return list(lex) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 269, in next token = self.get_token() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 96, in get_token raw = self.read_token() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 124, in read_token nextchar = self.instream.read(1) AttributeError: 'list' object has no attribute 'read' This was broken by r238475 BUG=321352 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/gyp_chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years ago (2013-12-03 23:34:50 UTC) #1
scottmg
lgtm
7 years ago (2013-12-03 23:36:18 UTC) #2
Nico
tbr'ing to unbreak folks
7 years ago (2013-12-03 23:36:24 UTC) #3
Nico
7 years ago (2013-12-03 23:36:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r238486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698