Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1032503003: Use ZoomValuesEqual() instead of ==. (Closed)

Created:
5 years, 9 months ago by wjmaclean
Modified:
5 years, 9 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ZoomValuesEqual() instead of ==. Replace an unsafe comparison of zoom level values. BUG=none Committed: https://crrev.com/23434b4ea55effc339e163aa3641e46a4441f8e8 Cr-Commit-Position: refs/heads/master@{#321866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/ui/zoom/zoom_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
wjmaclean
One-liner, ptal?
5 years, 9 months ago (2015-03-23 19:25:30 UTC) #2
Fady Samuel
lgtm
5 years, 9 months ago (2015-03-23 19:26:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032503003/1
5 years, 9 months ago (2015-03-23 20:33:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 21:49:16 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 21:49:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23434b4ea55effc339e163aa3641e46a4441f8e8
Cr-Commit-Position: refs/heads/master@{#321866}

Powered by Google App Engine
This is Rietveld 408576698