Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1032473002: Ship "Upgrade Insecure Requests". (Closed)

Created:
5 years, 9 months ago by Mike West
Modified:
5 years, 9 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, mkwst+watchlist-csp_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ship "Upgrade Insecure Requests". This patch makes no functional changes, it simply removes the runtime guards in both CSP and FrameFetchContext in order to enable the upgrade insecure requests behavior by default. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/BDHLrC8UM-Y/amTCDlWJnk8J BUG=455674 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192493

Patch Set 1 #

Patch Set 2 : CSPTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M Source/core/frame/csp/CSPDirectiveList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicyTest.cpp View 1 2 chunks +0 lines, -24 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Mike West
WDYT, Yoav? As philipj@ requested, I'll give this a bit before landing, just in case ...
5 years, 9 months ago (2015-03-24 10:21:58 UTC) #2
Yoav Weiss
On 2015/03/24 10:21:58, Mike West wrote: > WDYT, Yoav? > > As philipj@ requested, I'll ...
5 years, 9 months ago (2015-03-24 10:27:07 UTC) #3
philipj_slow
LGTM
5 years, 9 months ago (2015-03-24 10:53:14 UTC) #4
Mike West
On 2015/03/24 at 10:53:14, philipj wrote: > LGTM No objections overnight. I'll land this, and ...
5 years, 9 months ago (2015-03-25 04:44:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032473002/20001
5 years, 9 months ago (2015-03-25 04:45:15 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 05:33:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192493

Powered by Google App Engine
This is Rietveld 408576698