Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1032443002: [V8] Added debug-sourceinfo.js with LF endings back (Closed)

Created:
5 years, 9 months ago by kozy
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[V8] Added debug-sourceinfo.js with LF endings back Readded after https://codereview.chromium.org/1029063002/ with correct line endings. R=yangguo@chromium.org Committed: https://crrev.com/ed8394f1e3151abb268e2a0308e1a94378a63a6e Cr-Commit-Position: refs/heads/master@{#27370}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -0 lines) Patch
A test/mjsunit/debug-sourceinfo.js View 1 2 1 chunk +351 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kozy
Yang, ptal. More details in https://codereview.chromium.org/1029063002/
5 years, 9 months ago (2015-03-23 12:30:52 UTC) #1
Yang
On 2015/03/23 12:30:52, kozyatinskiy wrote: > Yang, ptal. More details in https://codereview.chromium.org/1029063002/ lgtm.
5 years, 9 months ago (2015-03-23 14:10:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032443002/40001
5 years, 9 months ago (2015-03-23 14:32:10 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-23 14:51:02 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 14:51:14 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ed8394f1e3151abb268e2a0308e1a94378a63a6e
Cr-Commit-Position: refs/heads/master@{#27370}

Powered by Google App Engine
This is Rietveld 408576698