Issue 103243002: Revert 238433 "Merge 233099 "Kill worker process by way of a syn..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 103243002: Revert 238433 "Merge 233099 "Kill worker process by way of a syn..." (Closed)

Created:
7 years ago by inferno

Modified:
7 years ago

Reviewers:
inferno

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 238433 "Merge 233099 "Kill worker process by way of a syn..." > Merge 233099 "Kill worker process by way of a sync IPC message b..." > > > Kill worker process by way of a sync IPC message before it cleans up. > > > > When a worker process shuts down, it shuts down WebKit. If there are > > other threads running in the worker process, this leads to crashes. > > This fix tries to kill the worker process forcibly so that no cleanup > > takes place. > > > > BUG=249502 > > > > Review URL: https://codereview.chromium.org/23496052 > > TBR=meacer@chromium.org > > Review URL: https://codereview.chromium.org/102543003 TBR=inferno@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238483

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -34 lines)			Patch
M	branches/1650/src/content/browser/worker_host/worker_process_host.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	branches/1650/src/content/browser/worker_host/worker_process_host.cc	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	branches/1650/src/content/common/worker_messages.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	branches/1650/src/content/worker/worker_thread.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	branches/1650/src/content/worker/worker_thread.cc	View	3 chunks	+0 lines, -17 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r238483.