Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1032323003: media: unittests: depend on xdisplaycheck for isolate (Closed)

Created:
5 years, 9 months ago by llandwerlin-old
Modified:
5 years, 9 months ago
Reviewers:
DaleCurtis, M-A Ruel
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: unittests: depend on xdisplaycheck for isolate BUG=470959 Committed: https://crrev.com/ff1d51c33ba28d2bfbc714aebe3856a104e2767d Cr-Commit-Position: refs/heads/master@{#322546}

Patch Set 1 #

Patch Set 2 : only depend on xdisplaycheck on x11 #

Total comments: 6

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M media/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/media.gyp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
llandwerlin-old
PTAL, Thanks.
5 years, 9 months ago (2015-03-26 18:45:38 UTC) #2
M-A Ruel
small style nits, logic is good. https://codereview.chromium.org/1032323003/diff/20001/media/media.gyp File media/media.gyp (right): https://codereview.chromium.org/1032323003/diff/20001/media/media.gyp#newcode1419 media/media.gyp:1419: ['use_alsa==1', { do ...
5 years, 9 months ago (2015-03-26 19:44:12 UTC) #4
DaleCurtis
lgtm % maruel's nits.
5 years, 9 months ago (2015-03-26 20:30:02 UTC) #5
llandwerlin-old
https://codereview.chromium.org/1032323003/diff/20001/media/media.gyp File media/media.gyp (right): https://codereview.chromium.org/1032323003/diff/20001/media/media.gyp#newcode1419 media/media.gyp:1419: ['use_alsa==1', { On 2015/03/26 19:44:11, M-A Ruel wrote: > ...
5 years, 9 months ago (2015-03-26 22:28:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032323003/40001
5 years, 9 months ago (2015-03-27 09:29:12 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-27 10:43:01 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 10:43:43 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ff1d51c33ba28d2bfbc714aebe3856a104e2767d
Cr-Commit-Position: refs/heads/master@{#322546}

Powered by Google App Engine
This is Rietveld 408576698