Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: Source/core/html/imports/HTMLImportsController.h

Issue 1032293002: Oilpan: dispose an HTMLImportsController on document detach/removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: No need to call dispose() when destructing HTMLImportsController Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/imports/HTMLImportTreeRoot.cpp ('k') | Source/core/html/imports/HTMLImportsController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/imports/HTMLImportsController.h
diff --git a/Source/core/html/imports/HTMLImportsController.h b/Source/core/html/imports/HTMLImportsController.h
index b175284b4ad911a43ca51cd2500bc9b74c711c44..3b902984dbbd67ef96a4f92bb8d2553ea7ce33e8 100644
--- a/Source/core/html/imports/HTMLImportsController.h
+++ b/Source/core/html/imports/HTMLImportsController.h
@@ -32,22 +32,19 @@
#define HTMLImportsController_h
#include "core/dom/DocumentSupplementable.h"
-#include "core/fetch/RawResource.h"
-#include "core/html/LinkResource.h"
-#include "core/html/imports/HTMLImport.h"
-#include "platform/Supplementable.h"
-#include "platform/Timer.h"
+#include "platform/heap/Handle.h"
#include "wtf/FastAllocBase.h"
-#include "wtf/PassOwnPtr.h"
#include "wtf/Vector.h"
namespace blink {
class FetchRequest;
+class HTMLImport;
class HTMLImportChild;
class HTMLImportChildClient;
class HTMLImportLoader;
class HTMLImportTreeRoot;
+class KURL;
class HTMLImportsController final : public NoBaseWillBeGarbageCollectedFinalized<HTMLImportsController>, public DocumentSupplement {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(HTMLImportsController);
@@ -79,8 +76,10 @@ public:
private:
HTMLImportChild* createChild(const KURL&, HTMLImportLoader*, HTMLImport* parent, HTMLImportChildClient*);
+ void dispose();
+
OwnPtrWillBeMember<HTMLImportTreeRoot> m_root;
- typedef WillBeHeapVector<OwnPtrWillBeMember<HTMLImportLoader>> LoaderList;
+ using LoaderList = WillBeHeapVector<OwnPtrWillBeMember<HTMLImportLoader>>;
LoaderList m_loaders;
};
« no previous file with comments | « Source/core/html/imports/HTMLImportTreeRoot.cpp ('k') | Source/core/html/imports/HTMLImportsController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698