Source/core/html/imports/HTMLImportChild.h - Issue 1032293002: Oilpan: dispose an HTMLImportsController on document detach/removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/imports/HTMLImportChild.h

Issue 1032293002: Oilpan: dispose an HTMLImportsController on document detach/removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: No need to call dispose() when destructing HTMLImportsController Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/imports/HTMLImportChild.h

diff --git a/Source/core/html/imports/HTMLImportChild.h b/Source/core/html/imports/HTMLImportChild.h

index 0c8e9bad8727881862204c7ce622e9b47b5895aa..725c9dad19724697a6cb220c309c82a260afad6b 100644

--- a/Source/core/html/imports/HTMLImportChild.h

+++ b/Source/core/html/imports/HTMLImportChild.h

@@ -53,6 +53,7 @@ class HTMLImportChild final : public HTMLImport {

public:

HTMLImportChild(const KURL&, HTMLImportLoader*, SyncMode);

virtual ~HTMLImportChild();

+ void dispose();

HTMLLinkElement* link() const;

const KURL& url() const { return m_url; }

@@ -61,7 +62,6 @@ public:

void didShareLoader();

void didStartLoading();

#if !ENABLE(OILPAN)

- void importDestroyed();

WeakPtr<HTMLImportChild> weakPtr() { return m_weakFactory.createWeakPtr(); }

#endif

« no previous file with comments | « no previous file | Source/core/html/imports/HTMLImportChild.cpp » ('j') | no next file with comments »