Issue 1032273005: Add missing export and import source files to password_manager's browser target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1032273005: Add missing export and import source files to password_manager's browser target. (Closed)

Created:
5 years, 8 months ago by tfarina

Modified:
5 years, 8 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, brettw, Dirk Pranke

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add missing export and import source files to password_manager's browser target. This was found by looking at the output of gyp_flag_compare step in http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/25653/steps/gyp_flag_compare/logs/stdio BUG=461019 TEST=gn gen out-gn R=isherman@chromium.org Committed: https://crrev.com/06ca24d5377de8a5ee0ea50bb1378423da6a8092 Cr-Commit-Position: refs/heads/master@{#322468}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	components/password_manager/core/browser/BUILD.gn	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032273005/20001

5 years, 8 months ago (2015-03-26 21:03:13 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-03-26 21:15:21 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/06ca24d5377de8a5ee0ea50bb1378423da6a8092
Cr-Commit-Position: refs/heads/master@{#322468}