Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1032273004: Revert of precache: Move the java files into //components/precache/android (Closed)

Created:
5 years, 9 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, bengr, Yaron, sadrul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of precache: Move the java files into //components/precache/android (patchset #5 id:120001 of https://codereview.chromium.org/1031003003/) Reason for revert: This broke downstream chrome for android. Coordination with chrome os is required. See bug for more details. Original issue's description: > precache: Move the java files into //components/precache/android > > This moves code out of //java/apps/chrome/.../precache into: > . //components/precache/android/: classes that provide information about > device-state, network connectivity etc. > . //chrome/android/.../precache/: precache service and service launchers. > > BUG=401552 > > Committed: https://crrev.com/efb5a13547940947b2c8f42a4e9ed64d45bdd2d2 > Cr-Commit-Position: refs/heads/master@{#322298} TBR=bengr@chromium.org,yfriedman@chromium.org,thestig@chromium.org,sadrul@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=401552 Committed: https://crrev.com/28464ce3eebbc11c4773f8b0679ee9000b495ef1 Cr-Commit-Position: refs/heads/master@{#322355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1415 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java View 1 chunk +0 lines, -211 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncher.java View 1 chunk +0 lines, -223 lines 0 comments Download
M chrome/android/javatests/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/precache/MockPrecacheService.java View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncherTest.java View 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceTest.java View 1 chunk +0 lines, -132 lines 0 comments Download
M chrome/android/shell/java/AndroidManifest.xml.jinja2 View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/android/precache/precache_launcher.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/android/precache/precache_launcher.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/precache.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/precache/android/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D components/precache/android/java/src/org/chromium/components/precache/DeviceState.java View 1 chunk +0 lines, -79 lines 0 comments Download
D components/precache/android/java/src/org/chromium/components/precache/NetworkInfoDelegate.java View 1 chunk +0 lines, -61 lines 0 comments Download
D components/precache/android/java/src/org/chromium/components/precache/NetworkInfoDelegateFactory.java View 1 chunk +0 lines, -16 lines 0 comments Download
D components/precache/android/javatests/src/org/chromium/components/precache/DeviceStateTest.java View 1 chunk +0 lines, -184 lines 0 comments Download
D components/precache/android/javatests/src/org/chromium/components/precache/MockDeviceState.java View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alex clarke (OOO till 29th)
Created Revert of precache: Move the java files into //components/precache/android
5 years, 9 months ago (2015-03-26 11:23:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032273004/1
5 years, 9 months ago (2015-03-26 11:24:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 11:25:00 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/28464ce3eebbc11c4773f8b0679ee9000b495ef1 Cr-Commit-Position: refs/heads/master@{#322355}
5 years, 9 months ago (2015-03-26 11:25:44 UTC) #4
sadrul
5 years, 9 months ago (2015-03-27 17:10:19 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1036363002/ by sadrul@chromium.org.

The reason for reverting is: Reland the patch. Downstream will be updated
shortly..

Powered by Google App Engine
This is Rietveld 408576698