dbus/object_proxy.cc - Issue 1032263002: Stop deleting ObjectProxy::OnPendingCallIsCompleteData manually

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus/object_proxy.cc

Issue 1032263002: Stop deleting ObjectProxy::OnPendingCallIsCompleteData manually (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dbus/object_proxy.cc

diff --git a/dbus/object_proxy.cc b/dbus/object_proxy.cc

index 7347db0ad726fd8e35d1d0624b5093caccd15648..974b24c57d11688335f341af6a1c1c3d942ed86d 100644

--- a/dbus/object_proxy.cc

+++ b/dbus/object_proxy.cc

@@ -275,7 +275,7 @@ void ObjectProxy::StartAsyncMethodCall(int timeout_ms,

pending_call,

&ObjectProxy::OnPendingCallIsCompleteThunk,

data,

- NULL);

+ &DeleteVoidPointer<OnPendingCallIsCompleteData>);

CHECK(success) << "Unable to allocate memory";

dbus_pending_call_unref(pending_call);

@@ -367,7 +367,6 @@ void ObjectProxy::OnPendingCallIsCompleteThunk(DBusPendingCall* pending_call,

data->response_callback,

data->error_callback,

data->start_time);

- delete data;

}

bool ObjectProxy::ConnectToNameOwnerChangedSignal() {

« no previous file with comments | « no previous file | dbus/util.h » ('j') | no next file with comments »